Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dao vote amount checks #16988

Merged
merged 7 commits into from
Dec 8, 2023
Merged

dao vote amount checks #16988

merged 7 commits into from
Dec 8, 2023

Conversation

geoffwalmsley
Copy link
Contributor

@geoffwalmsley geoffwalmsley commented Dec 3, 2023

  1. The proposal and validator puzzles check the total votes and yes vote amounts using >, changed to use gte so that we don't raise if the actuals are the same as target.
  2. Added gte and lte into utility_macros.
  3. Wallets joining the DAO need to know the cat origin details so they can close mint proposals. We can include the cat_origin and launcher IDs in the memos of the DAO creation spend. Syncing wallets can then grab this from the solution when they're setting up.
  4. Other minor fixes:
  • prevent creating dao with the same timelock and self-destruct
  • display correct asset id for DAO_CAT wallet
  • only run exlit lockup if there are coins to spend
  • prevent fake p2_singletons being added to treasury
  • calculate the CAT tail from the memo data (added in extra fields to the memo to enable this)
  • increment index in add_or_update_proposal loop

@geoffwalmsley geoffwalmsley added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Dec 3, 2023
@geoffwalmsley geoffwalmsley requested a review from a team as a code owner December 3, 2023 21:06
matt-o-how
matt-o-how previously approved these changes Dec 8, 2023
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@cmmarslender cmmarslender merged commit ca9a601 into release/2.1.2 Dec 8, 2023
@cmmarslender cmmarslender deleted the gw.gte_vote_amounts branch December 8, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants