Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chia show keys --show-mnemonic-seed: Also show farmer private key #16556

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

xearl4
Copy link
Contributor

@xearl4 xearl4 commented Oct 9, 2023

Technically, the farmer process alone doesn't need the master secret key, but only the farmer secret key. This change therefore makes it easier to retrieve this derived secret key.

Technically, the farmer process alone doesn't need the master secret
key, but only the farmer secret key. This change therefore makes it
easier to retrieve this derived secret key.
@xearl4 xearl4 requested a review from a team as a code owner October 9, 2023 08:35
@xearl4
Copy link
Contributor Author

xearl4 commented Oct 9, 2023

Additional thoughts:

  • We could show the pool secret key as well, if we think that helps OP plot farmers in some way.
  • I'd like to harmonise naming between "master private key" and "wallet secret key" and use "secret key" everywhere. But I'm not sure what stability requirements you have on the CLI output.

@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 6454238833

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 106 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.1%) to 89.417%

Files with Coverage Reduction New Missed Lines %
chia/wallet/util/wallet_sync_utils.py 1 77.21%
tests/simulation/test_simulation.py 1 96.53%
chia/server/node_discovery.py 2 77.49%
chia/timelord/timelord_api.py 2 87.85%
chia/full_node/full_node.py 3 85.5%
chia/server/server.py 4 79.54%
chia/full_node/full_node_api.py 7 77.68%
chia/daemon/server.py 8 86.19%
chia/wallet/wallet_node.py 9 87.03%
chia/timelord/timelord_state.py 20 69.47%
Totals Coverage Status
Change from base Build 6435114887: -0.1%
Covered Lines: 87428
Relevant Lines: 97730

💛 - Coveralls

Copy link
Contributor

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Nov 24, 2023
@emlowe emlowe added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Nov 27, 2023
paninaro
paninaro previously approved these changes Nov 27, 2023
@paninaro
Copy link
Contributor

@xchdata1 Thanks for the change. Would you be able to update the PR to target the release/2.1.2 branch?

@paninaro paninaro removed the stale-pr Flagged as stale and in need of manual review label Nov 27, 2023
@xearl4 xearl4 changed the base branch from main to release/2.1.2 November 30, 2023 18:32
@xearl4 xearl4 dismissed paninaro’s stale review November 30, 2023 18:32

The base branch was changed.

@xearl4
Copy link
Contributor Author

xearl4 commented Nov 30, 2023

@xchdata1 Thanks for the change. Would you be able to update the PR to target the release/2.1.2 branch?

Sure, done!

@cmmarslender cmmarslender merged commit fde036c into Chia-Network:release/2.1.2 Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants