cleanup unused peer config #14922
Merged
cleanup unused peer config #14922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altendky
added
Changed
xdustinface
reviewed
Mar 28, 2023
github-actions
bot
added
the
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
added
the
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties. |
github-actions
bot
added
the
stale-pr
github-actions
bot
removed
the
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
emlowe
approved these changes
Oct 10, 2023
fchirica
pushed a commit
that referenced
this pull request
Oct 17, 2023
This was referenced Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Provide clarity around which services use which ports by removing the unused port config entries.
Current Behavior:
There are unused port config entries.
New Behavior:
The default config file is cleaner and the configure command doesn't update the unused port entries.
Testing Notes:
Draft For:
nmapclaims it isn't openlistenintoadvertised_portasNone#15024