Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vulnerabilities and tests, upgrade packages and CLI version (AST-38513) #160

Merged
merged 15 commits into from
May 8, 2024
Merged

Fix vulnerabilities and tests, upgrade packages and CLI version (AST-38513) #160

merged 15 commits into from
May 8, 2024

Conversation

checkmarx-kobi-hagmi
Copy link
Contributor

@checkmarx-kobi-hagmi checkmarx-kobi-hagmi commented May 5, 2024 •
edited
Loading

Description

Fix vulnerabilities and tests, upgrade packages and CLI to version 2.1.0

References

https://checkmarx.atlassian.net/browse/AST-38513

Testing

Manually tested and verified

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@pedrompflopes pedrompflopes requested a review from a team May 5, 2024 06:52
@pedrompflopes pedrompflopes requested review from margaritalm and helderfvieira and removed request for a team May 5, 2024 06:52
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – ae5c2ae7-93a2-4a19-a3a9-df4b5711e2e0

Policy Management Violations

Policy Name Rule(s) Break Build
[SAST-ML0] Not allowed NEW Sast vulnerabilities true

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 115
MEDIUM Unpinned Actions Full Length Commit SHA /pr-label.yml: 15
MEDIUM Unpinned Actions Full Length Commit SHA /nightly.yml: 32
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 85
MEDIUM Unpinned Actions Full Length Commit SHA /update-cli.yml: 33
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 74
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 93
MEDIUM Unpinned Actions Full Length Commit SHA /ci.yml: 20
MEDIUM Unpinned Actions Full Length Commit SHA /dependabot-auto-merge.yml: 23
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 127
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 45
MEDIUM Unpinned Actions Full Length Commit SHA /dependabot-auto-merge.yml: 14
MEDIUM Unpinned Actions Full Length Commit SHA /ast-scan.yml: 12
MEDIUM Unpinned Actions Full Length Commit SHA /ci.yml: 17

@checkmarx-kobi-hagmi checkmarx-kobi-hagmi changed the title Fix tests, upgrade packages and CLI Fix tests, upgrade packages and CLI version May 7, 2024
@checkmarx-kobi-hagmi checkmarx-kobi-hagmi changed the title Fix tests, upgrade packages and CLI version Fix Vulnerabilities and tests, upgrade packages and CLI version May 7, 2024
@checkmarx-kobi-hagmi checkmarx-kobi-hagmi changed the title Fix Vulnerabilities and tests, upgrade packages and CLI version Fix vulnerabilities and tests, upgrade packages and CLI version May 7, 2024
@checkmarx-kobi-hagmi checkmarx-kobi-hagmi changed the title Fix vulnerabilities and tests, upgrade packages and CLI version Fix vulnerabilities and tests, upgrade packages and CLI version (AST-38513) May 8, 2024
OrShamirCM
OrShamirCM reviewed May 8, 2024
View reviewed changes
ast-visual-studio-extension-tests/cx-unit-tests/cx-wrapper-tests/ResultTest.cs
@@ -49,7 +49,7 @@ public void TestResultsSummaryJSON()
[Fact]
public void TestResultsStructure()
{
List<Scan> scanList = cxWrapper.GetScans();
List<Scan> scanList = cxWrapper.GetScans("statuses=Completed");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you add it here?

@checkmarx-kobi-hagmi checkmarx-kobi-hagmi merged commit 0a62cd0 into main May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrShamirCM OrShamirCM OrShamirCM approved these changes

@AlvoBen AlvoBen AlvoBen approved these changes

@margaritalm margaritalm Awaiting requested review from margaritalm margaritalm was automatically assigned from Checkmarx/ast-galactica-team

@helderfvieira helderfvieira Awaiting requested review from helderfvieira helderfvieira was automatically assigned from Checkmarx/ast-galactica-team

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@checkmarx-kobi-hagmi @OrShamirCM @AlvoBen