Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address clang-tidy warnings #5915

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Feb 7, 2025

  • Adds /* tag */ to tag argument in tag_invoke
  • Removes std::move for (known) trivially copyable types - we have to emulate std::is_trivially_copyable a bit. We have static_asserts to make sure that's actually true
  • Uses std::move for vectors (they were copied before)
  • Types without members won't create a root variable anymore

Fixes #5913.

@pajlada pajlada enabled auto-merge (squash) February 7, 2025 17:53
@pajlada pajlada merged commit 9092f24 into Chatterino:master Feb 7, 2025
18 checks passed
@Nerixyz Nerixyz deleted the fix/clang-tidy-warnings branch February 7, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of clang-tidy warnings in generated code (trivial moves and unnamed arguments)
2 participants