Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context menu entry to toggle offline tabs #5318

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Apr 11, 2024

Adds an entry to toggle the visibility of offline tabs, as mentioned in #5315 (comment).

I'll note that the context menus for the notebook, split-header and the menu of a split are shown when pressing the mouse, not when releasing it, which is unintuitive.

@pajlada
Copy link
Member

pajlada commented Apr 12, 2024

I'll note that the context menus for the notebook, split-header and the menu of a split are shown when pressing the mouse, not when releasing it, which is unintuitive.

This is a platform-specific discrepancy we have. On Linux, the norm is to show the menu on mouse-down rather than mouse-up

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - there's some UX improvements that could be done with tab visibility in general but that doesn't have to be completed in this PR, or in this release. This will already help reduce support traffic of "oops all my tabs are gone"

@pajlada pajlada merged commit 1ca77a1 into Chatterino:master Apr 12, 2024
17 checks passed
@Nerixyz Nerixyz deleted the feat/toggle-offline-entry branch April 12, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants