Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync channels with browser #4741

Merged
merged 5 commits into from
Aug 5, 2023
Merged

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Jul 31, 2023

Description

In conjunction with Chatterino/chatterino-browser-ext#95.

This PR warms channels that are open in the browser, which results in a better experience when switching tabs in the browser (described in more detail in #4146). Channels that were already open will only have their reference-count incremented.

Fixes #4146.

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks, will require changes in the extension PR too

src/singletons/NativeMessaging.cpp Outdated Show resolved Hide resolved
src/singletons/NativeMessaging.hpp Show resolved Hide resolved
@pajlada pajlada enabled auto-merge August 5, 2023 11:23
@pajlada pajlada added this pull request to the merge queue Aug 5, 2023
Merged via the queue into Chatterino:master with commit 1438529 Aug 5, 2023
Nerixyz added a commit to Nerixyz/chatterino2 that referenced this pull request Aug 12, 2023
* feat: keep channels from browser tabs alive

* chore: add changelog entry

* fix: add comment

* fix: rename key

---------

Co-authored-by: pajlada <[email protected]>
Nerixyz added a commit to Nerixyz/chatterino2 that referenced this pull request Aug 19, 2023
* feat: keep channels from browser tabs alive

* chore: add changelog entry

* fix: add comment

* fix: rename key

---------

Co-authored-by: pajlada <[email protected]>
@Nerixyz Nerixyz deleted the feat/tab-warming branch October 6, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/watching Tab Parts Channels Even Though Browser Tab Is Still Open
2 participants