Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 新增阿里系模型代码配置 #5740

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

yuxuan-ctrl
Copy link
Contributor

@yuxuan-ctrl yuxuan-ctrl commented Oct 30, 2024

Pull Request

💻 变更类型 | Change Type

  • feat
  • fix
  • refactor
  • perf
  • style
  • test
  • docs
  • ci
  • chore
  • build

🔀 变更说明 | Description of Change

添加阿里云 DashScope API 代理配置,支持通过 /api/proxy/alibaba 路径访问阿里云 AI 服务。

具体变更:

  • 在 next.config.mjs 中新增阿里云 DashScope API 的代理配置
  • 将请求从 /api/proxy/alibaba/* 转发到 https://dashscope.aliyuncs.com/api/*

变更代码: 添加 {
source: "/api/proxy/alibaba/:path*",
destination: "https://dashscope.aliyuncs.com/api/:path*",
},

Summary by CodeRabbit

  • New Features
    • Introduced a new API proxy route for Alibaba, allowing seamless integration for requests directed to /api/proxy/alibaba/:path*.
  • Enhancements
    • Improved handling of CORS headers for API routes based on build mode.
    • Maintained existing configurations for image optimization and SVG handling.

Copy link

vercel bot commented Oct 30, 2024

@yuxuan-ctrl is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Oct 30, 2024

Walkthrough

The changes in this pull request focus on updating the next.config.mjs file to enhance API proxy route handling. A new proxy route for Alibaba has been introduced, allowing requests to be directed to a specified Alibaba API endpoint. This addition is conditional, only executing when the build mode is not set to "export". The configuration also maintains existing CORS headers and image optimization setups, while the webpack configuration remains unchanged.

Changes

File Change Summary
next.config.mjs Added a new proxy route for Alibaba: /api/proxy/alibaba/:path* directing to https://dashscope.aliyuncs.com/api/:path*. Updated CORS headers and rewrites for API routes, with no changes to the webpack configuration.

Possibly related PRs

  • feat: qwen #4942: This PR introduces a handler for Alibaba API requests, which is directly related to the new proxy route for Alibaba added in the main PR's next.config.mjs.

Suggested reviewers

  • lloydzhou

🐇 In the meadow, I hop and play,
New routes for Alibaba brighten the day.
With proxies set and CORS in line,
Our API's ready, oh how it will shine!
Hopping along, with joy I proclaim,
Configuration magic, oh what a game! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 613d67e and 86ffa1e.

📒 Files selected for processing (1)
  • next.config.mjs (1 hunks)
🔇 Additional comments (2)
next.config.mjs (2)

97-100: LGTM on proxy route configuration.

The proxy route configuration:

  • Follows the established pattern of other API proxies
  • Correctly maintains the API path structure
  • Is properly placed within the rewrites array

97-100: Verify security measures for the new Alibaba proxy route.

While the proxy configuration follows the established pattern, consider implementing additional security measures:

  1. Rate limiting to prevent abuse
  2. Path validation to restrict access to specific API endpoints
  3. Request size limits

Let's verify the proxy route configuration:

✅ Verification successful

Security measures are properly implemented for the Alibaba proxy route

The verification reveals that the proxy route is adequately secured through multiple layers:

  1. Authentication middleware that validates access codes and API keys
  2. Request timeout protection (10 minutes)
  3. Model availability checks against server configuration
  4. Proper error handling and logging
  5. Security headers management (removing www-authenticate, setting X-Accel-Buffering)

The implementation follows the same security patterns as other provider integrations in the codebase, with proper authorization checks through the auth() function before proxying requests.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify proxy route configuration and potential security implications

# Test 1: Check for any duplicate proxy routes that might conflict
echo "Checking for duplicate proxy routes..."
rg -l "dashscope\.aliyuncs\.com" --type js

# Test 2: Verify the presence of security middleware for API routes
echo "Checking for API security middleware..."
rg -l "middleware.*api.*proxy" --type ts --type js

# Test 3: Look for rate limiting implementations
echo "Checking for rate limiting implementations..."
rg -l "rate.*limit.*api" --type ts --type js

Length of output: 421


Script:

#!/bin/bash
# Let's try a different approach to verify security measures

# Check for middleware files and their content
echo "=== Checking for API middleware files ==="
fd middleware

# Look for any authentication or security related code in middleware
echo -e "\n=== Checking middleware content ==="
rg -l "auth|protect|secure" --type ts --type js $(fd middleware)

# Check for rate limiting implementations with broader search
echo -e "\n=== Checking for rate limiting (broader search) ==="
rg -l "rateLimit|limiter" --type ts --type js

# Look for proxy route configurations to understand the pattern
echo -e "\n=== Checking proxy configurations ==="
rg "source.*:/api/proxy/" next.config.mjs -A 2

# Check for any security headers or configurations
echo -e "\n=== Checking security headers configuration ==="
rg "headers|security" next.config.mjs

Length of output: 1960


Script:

#!/bin/bash
# Let's check the API proxy implementation and security measures

# Check the proxy API implementation
echo "=== Checking proxy API implementation ==="
rg -A 10 "export.*function.*proxy" app/api/proxy.ts

# Check the Alibaba API implementation
echo -e "\n=== Checking Alibaba API implementation ==="
cat app/api/alibaba.ts

# Check CORS and security headers configuration
echo -e "\n=== Checking CORS configuration ==="
rg -A 5 "CorsHeaders" --type ts --type js

# Check authentication implementation for API routes
echo -e "\n=== Checking API route authentication ==="
cat app/api/auth.ts

# Look for request validation or sanitization
echo -e "\n=== Checking request validation ==="
rg "validate|sanitize|check" app/api/proxy.ts app/api/alibaba.ts

Length of output: 7572

next.config.mjs Show resolved Hide resolved
@lloydzhou lloydzhou merged commit d0bd1bf into ChatGPTNextWeb:main Oct 30, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants