-
Notifications
You must be signed in to change notification settings - Fork 59.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add constant to claude 3.5 sonnet 20241022 #5737
Conversation
@hyiip is attempting to deploy a commit to the NextChat Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes involve the addition of a new model name, Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
π§Ή Outside diff range and nitpick comments (1)
app/constant.ts (1)
322-322
: Consider adding knowledge cutoff date for the new model.
The KnowledgeCutOffDate mapping (around line 300) should be updated to include the knowledge cutoff date for this new model to maintain consistency with other models.
Example addition:
export const KnowledgeCutOffDate: Record<string, string> = {
default: "2021-09",
+ "claude-3-5-sonnet-20241022": "2024-10", // Update with actual cutoff date
// ... other models
};
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
π Files selected for processing (1)
- app/constant.ts (1 hunks)
π Additional comments (1)
app/constant.ts (1)
322-322
: LGTM! Model name follows the established pattern.
The addition of "claude-3-5-sonnet-20241022" is consistent with the existing naming convention and is properly integrated into the anthropicModels array.
π» εζ΄η±»ε | Change Type
π εζ΄θ―΄ζ | Description of Change
Add support to claude 3.5 sonnet 20241022 version.
π θ‘₯ε δΏ‘ζ― | Additional Information
Summary by CodeRabbit
claude-3-5-sonnet-20241022
, expanding the options available for the Anthropic provider.