Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid fetching prompts.json serverside #5462

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

JuliusMoehring
Copy link
Contributor

@JuliusMoehring JuliusMoehring commented Sep 18, 2024

πŸ’» ε˜ζ›΄η±»εž‹ | Change Type

  • feat
  • fix
  • refactor
  • perf
  • style
  • test
  • docs
  • ci
  • chore
  • build

πŸ”€ ε˜ζ›΄θ―΄ζ˜Ž | Description of Change

Running fetch with a relative path in not possible server side. To avoid the fetching server side, checking if window is undefined and doing an early return if so resolves the issue.

πŸ“ θ‘₯充俑息 | Additional Information

This fix should resolve:

Copy link

vercel bot commented Sep 18, 2024

@JuliusMoehring is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Sep 18, 2024

Walkthrough

The changes involve reordering import statements and adding a conditional check in the onRehydrateStorage function of the usePromptStore. The new check prevents the rehydration of the store when executed on the server side, ensuring that the store's state remains consistent and avoids issues related to incorrect rehydration in a server environment.

Changes

Files Change Summary
app/store/prompt.ts Reordered import statements; added a conditional check to skip store rehydration on the server side.

Suggested reviewers

  • Dogtiti

Poem

In the code where bunnies hop,
A check was added, a clever stop.
No more rehydration on the server's side,
Keeping our data safe, with pride!
So here’s to changes, both big and small,
A happy store, we’ll cherish it all! πŸ‡βœ¨


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a8c70d8 and accb526.

Files selected for processing (1)
  • app/store/prompt.ts (2 hunks)
Additional comments not posted (1)
app/store/prompt.ts (1)

150-154: LGTM!

The added conditional check correctly prevents the store's rehydration on the server side, enhancing the robustness of the code. This change ensures that the store's state is not incorrectly rehydrated in a server environment, avoiding potential issues with data consistency or unexpected behavior.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@JuliusMoehring JuliusMoehring changed the title Avoid fetching prompts.json serverside fix: Avoid fetching prompts.json serverside Sep 18, 2024
Copy link
Contributor

Your build has completed!

Preview deployment

@Dogtiti Dogtiti merged commit b5ba05d into ChatGPTNextWeb:main Sep 19, 2024
1 of 2 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Oct 8, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants