Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve setting.model selector #5431

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

tuanzisama
Copy link
Contributor

@tuanzisama tuanzisama commented Sep 14, 2024

πŸ’» ε˜ζ›΄η±»εž‹ | Change Type

  • feat
  • fix
  • refactor
  • perf
  • style
  • test
  • docs
  • ci
  • chore
  • build

πŸ”€ ε˜ζ›΄θ―΄ζ˜Ž | Description of Change

Improved model selector on settings page

a6665e47840a997e8e157464d3556c0e

πŸ“ θ‘₯充俑息 | Additional Information

Summary by CodeRabbit

  • New Features

    • Enhanced model selection dropdown with grouped models by provider for improved usability.
    • Introduced optional alignment property for select components, allowing left or center alignment.
  • Style

    • Added .left-align-option CSS class for consistent left text alignment in dropdown options.

Copy link

vercel bot commented Sep 14, 2024

@tuanzisama is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Sep 14, 2024

Walkthrough

The changes enhance the ModelConfigList component by implementing a grouping mechanism for models in the selection dropdown, organized by provider names. The Select component now supports an alignment property, allowing options to be aligned left or centered. Additionally, a new CSS class is introduced to ensure left alignment of dropdown options, improving the overall layout and usability of the model selection interface.

Changes

File Change Summary
app/components/model-config.tsx Introduced grouping of models by provider names in the dropdown using lodash-es.
app/components/ui-lib.module.scss Added a new CSS class .left-align-option for left text alignment of dropdown options.
app/components/ui-lib.tsx Enhanced Select component props with an optional align property for flexible alignment options.

Possibly related PRs

Poem

In a dropdown where models play,
Grouped by providers, hip-hip-hooray!
Left-align the options, neat and bright,
A user-friendly view, oh what a sight!
Hoppity hop, let’s select with glee,
A better interface for you and me! πŸ‡βœ¨

Tip

OpenAI O1 model for chat
  • We have deployed OpenAI's latest O1 model for chat.
  • OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
  • Please share any feedback with us in the discussions post.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4eb4c31 and 84a7afc.

Files selected for processing (3)
  • app/components/model-config.tsx (3 hunks)
  • app/components/ui-lib.module.scss (1 hunks)
  • app/components/ui-lib.tsx (1 hunks)
Additional comments not posted (6)
app/components/ui-lib.module.scss (1)

255-259: LGTM!

The new .left-align-option class is a useful addition that enhances the styling options for select dropdowns. The class name follows the BEM naming convention, making it clear and maintainable. The styles are properly scoped within the .select-with-icon class, ensuring they only apply to the intended select dropdowns.

Great work on improving the flexibility of the UI components!

app/components/model-config.tsx (4)

8-8: LGTM!

The import statement for the groupBy function from the lodash-es library is correctly written. This function is a useful utility for grouping elements of a collection by a given key.


15-18: Excellent implementation!

The introduction of the groupModels constant to group the available models by their provider names using the groupBy function is a great enhancement to the model selector. It improves the organization and usability of the model selection interface by presenting the models in a structured manner based on their providers.

Filtering the models to only include the available ones before grouping is also a good practice to ensure that only the relevant models are displayed to the user.


27-27: Nice touch!

Setting the align prop of the Select component to "left" is a minor but effective change that improves the visual layout of the model selector. It ensures that the dropdown aligns properly with the rest of the UI elements.


36-44: Great job with the grouping implementation!

The code change correctly implements the grouping of models by their providers using <optgroup> elements. This enhances the organization and readability of the model selector.

Using the provider names as the label for the <optgroup> elements provides clear categorization of the models, making it easier for users to understand the available options.

Mapping the models to <option> elements within each <optgroup> ensures that the models are displayed under their respective providers, further improving the usability of the model selector.

app/components/ui-lib.tsx (1)

295-307: LGTM!

The changes to the Select function look good:

  • The new optional align prop is correctly destructured from the props object.
  • The align prop is used to conditionally apply the styles["left-align-option"] class when its value is "left".
  • The remaining props are correctly passed to the select element using the spread operator.

The changes are self-contained and do not affect other parts of the file. The AI-generated summary accurately describes the modifications made to the Select function.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

Your build has completed!

Preview deployment

@Dogtiti Dogtiti merged commit f379865 into ChatGPTNextWeb:main Sep 14, 2024
1 of 2 checks passed
@Tsenghan
Copy link

This is a nice, clear feature, why not also use it for the model selector in the chat interface?

@tuanzisama tuanzisama deleted the tuanzisama-patch-1 branch September 30, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants