Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat UI/UX Page [Settings] #3383

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Feat UI/UX Page [Settings] #3383

merged 4 commits into from
Nov 27, 2023

Conversation

H0llyW00dzZ
Copy link
Contributor

  • [+] fix(auth.tsx): fix condition to set custom endpoint to true if it's app
  • [+] refactor(auth.tsx): update accessStore to set useCustomConfig to true

A Preview:

Screenshot_378

- [+] fix(auth.tsx): fix condition to set custom endpoint to true if it's app
- [+] refactor(auth.tsx): update accessStore to set useCustomConfig to true
- [+] feat(settings.tsx): set useCustomConfig to true if clientConfig.isApp is truthy
@H0llyW00dzZ H0llyW00dzZ changed the title Fix & Refactor UI/UX Page [Auth] Fix & Refactor UI/UX Page [Auth] [Settings] Nov 27, 2023
@H0llyW00dzZ H0llyW00dzZ changed the title Fix & Refactor UI/UX Page [Auth] [Settings] Feat UI/UX Page [Settings] Nov 27, 2023
This reverts commit d76e744.

Reason: Move to commits bf5e7aa
- [+] fix(settings.tsx): fix conditional rendering of ListItem based on clientConfig.isApp
- [+] refactor(settings.tsx): improve readability of conditional rendering code
@H0llyW00dzZ
Copy link
Contributor Author

a preview for app:

image

Note

This are correct for app (desktop app) because while you using app (desktop app), it will used https://deploy.com/api/proxy/ instead of /api/openai (this /api/openai as default are for non app)

@Yidadaa
Copy link
Collaborator

Yidadaa commented Nov 27, 2023

lgtm

@Yidadaa Yidadaa merged commit 2c12be6 into ChatGPTNextWeb:main Nov 27, 2023
1 check passed
@H0llyW00dzZ H0llyW00dzZ deleted the auth branch November 27, 2023 07:52
spongeBor pushed a commit to spongeBor/ChatGPT-Next-Web that referenced this pull request Jan 18, 2024
gaogao1030 pushed a commit to gaogao1030/ChatGPT-Next-Web that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants