-
Notifications
You must be signed in to change notification settings - Fork 59.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remediation of CVE-2023-2251 #2002
Conversation
@@ -56,5 +56,8 @@ | |||
"lint-staged": "^13.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also be pinned to ^13.2.2
: https://github.com/okonet/lint-staged/releases/tag/v13.2.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be something to consider. My objective was the path of least resistance but this is probably the way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yarn.lock
will also have to be updated (by running yarn install
).
Thanks for catching that @ThatOneCalculator. Still a yarn noob 🙃 |
No worries! You should run |
A vulnerability in npm package yaml was discovered in April this year. Details about this vulnerability can be reviewed here: GHSA-f9xv-q969-pqx4.
npm package lint-staged currently targets yaml version 2.2.1, which is an effected version of the package. This pull request resolves this issue by creating a package resolution for lint-staged, targeting version 2.2.2 and greater.