Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Refactor with React Router #643

Closed
Yidadaa opened this issue Apr 9, 2023 · 4 comments
Closed

[Feature] Refactor with React Router #643

Yidadaa opened this issue Apr 9, 2023 · 4 comments

Comments

@Yidadaa
Copy link
Collaborator

Yidadaa commented Apr 9, 2023 •
edited
Loading

We should use React Router to navigate between pages, this will make the development of future features simpler.

Related features: #640 #519 #138
@Yidadaa Yidadaa mentioned this issue Apr 10, 2023
Closed
@AprilNEA
Copy link
Contributor

Nextjs comes with routing functionality and should not use React Router

@AprilNEA
Copy link
Contributor

This will make significant changes to the current code and may affect most of the current PR

@Yidadaa
Copy link
Collaborator Author

Yidadaa commented Apr 11, 2023

@AprilNEA

I prefer to treat this project as a SPA app, and disable most of SSR rendering.

@AprilNEA
Copy link
Contributor

AprilNEA commented Apr 11, 2023 •
edited
Loading

SPA can also be implemented by routing, using Next.js's layout.ts and <Link/>.

Yidadaa added a commit that referenced this issue Apr 20, 2023
@Yidadaa
Merge pull request #959 from Yidadaa/0420-mask
a62bca4 
refactor: close #643 use react router
@Yidadaa Yidadaa mentioned this issue Apr 20, 2023
Closed
lileihappy123 pushed a commit to lileihappy123/ChatGPT-Next-Web that referenced this issue Apr 22, 2023
@Yidadaa @lileihappy123
refactor: close ChatGPTNextWeb#643 use react router
1536030
yxl pushed a commit to yxl/ChatGPT-Next-Web that referenced this issue May 4, 2023
@Yidadaa
refactor: close ChatGPTNextWeb#643 use react router
31048f7
yxl pushed a commit to yxl/ChatGPT-Next-Web that referenced this issue May 4, 2023
@Yidadaa
Merge pull request ChatGPTNextWeb#959 from Yidadaa/0420-mask
06d613f 
refactor: close ChatGPTNextWeb#643 use react router
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Yidadaa @AprilNEA