Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xcode 14.3 import warnings #5041

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Fix Xcode 14.3 import warnings #5041

merged 1 commit into from
Jun 8, 2023

Conversation

FelixHerrmann
Copy link
Contributor

Goals ⚽

Xcode 14.3 produces some missing import warnings:
Screenshot 2023-04-09 at 22 57 36

Implementation Details 🚧

I have added all the necessary imports to resolve the warnings.

Testing Details πŸ”

I have build the project with Xcode 14.2 and 14.3 for macOS and iOS.

@pmairoldi pmairoldi added this to the 5.0.0 milestone May 6, 2023
@pmairoldi
Copy link
Collaborator

I do not see such warnings on my end. How do you are building the project?

@FelixHerrmann
Copy link
Contributor Author

I do not see such warnings on my end. How do you are building the project?

As a Swift Package, so the same as it gets integrated into a Project via SPM.

I'm also seeing those warnings in Xcode Cloud builds:

Screenshot 2023-06-03 at 00 37 06

@FelixHerrmann
Copy link
Contributor Author

Also seeing them in Xcode 14.3.1 (released 3 days ago):
Screenshot 2023-06-04 at 20 35 18

@liuxuan30
Copy link
Member

@FelixHerrmann could you try 5.0 branch and see this issue still there, and maybe re-target this PR to 5.0 branch?

@FelixHerrmann
Copy link
Contributor Author

@FelixHerrmann could you try 5.0 branch and see this issue still there, and maybe re-target this PR to 5.0 branch?

Yes, it's still there and requires the same changes!

@FelixHerrmann FelixHerrmann changed the base branch from master to release/5.0.0 June 8, 2023 10:00
@pmairoldi pmairoldi merged commit 56b4f22 into ChartsOrg:release/5.0.0 Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants