Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove java interface convention #2795

Closed
wants to merge 3 commits into from
Closed

Remove java interface convention #2795

wants to merge 3 commits into from

Conversation

jjatie
Copy link
Collaborator

@jjatie jjatie commented Sep 18, 2017

All protocols prefaced with "I" have been renamed with the "I", following Swift API guidelines.
The concept of Interfaces were carried over from the Java implementation and don't belong here.
All DataSet "Interfaces" have been removed as they don't provide anything to the framework that subclassing doesn't already provide. This also makes DataSets like other related types including ChartData, DataEntries, ChartViews, etc.

jjatie and others added 2 commits September 17, 2017 08:35
All protocols prefaced with "I" have been renamed with the "I", following Swift API guidelines.
The concept of Interfaces were carried over from the Java implementation and don't belong here.
All DataSet "Interfaces" have been removed as they don't provide anything to the framework that subclassing doesn't already provide. This also makes DataSets like other related types including `ChartData`, DataEntries, `ChartView`s, etc.
@codecov-io
Copy link

codecov-io commented Sep 18, 2017

Codecov Report

Merging #2795 into master will increase coverage by <.01%.
The diff coverage is 24.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2795      +/-   ##
==========================================
+ Coverage   19.64%   19.64%   +<.01%     
==========================================
  Files         113      113              
  Lines       13792    13791       -1     
==========================================
  Hits         2709     2709              
+ Misses      11083    11082       -1
Impacted Files Coverage Δ
...Renderers/BarLineScatterCandleBubbleRenderer.swift 54.83% <ø> (ø) ⬆️
.../Implementations/Standard/BubbleChartDataSet.swift 0% <ø> (ø) ⬆️
...Charts/Renderers/Scatter/CircleShapeRenderer.swift 0% <ø> (ø) ⬆️
...plementations/Standard/LineRadarChartDataSet.swift 16.66% <ø> (ø) ⬆️
...rts/Renderers/LineScatterCandleRadarRenderer.swift 9.09% <ø> (ø) ⬆️
.../Implementations/Standard/CandleChartDataSet.swift 0% <ø> (ø) ⬆️
...ource/Charts/Formatters/DefaultFillFormatter.swift 5% <ø> (ø) ⬆️
...ce/Charts/Formatters/IndexAxisValueFormatter.swift 0% <ø> (ø) ⬆️
...ata/Implementations/Standard/PieChartDataSet.swift 0% <ø> (ø) ⬆️
...ata/Implementations/Standard/BarChartDataSet.swift 57.74% <ø> (ø) ⬆️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98552bb...aa9eec2. Read the comment docs.

@jjatie jjatie closed this Nov 6, 2017
@jjatie jjatie deleted the remove_java_interface_convention branch November 6, 2017 21:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants