AnimatedMoveViewJob crash

[Ramonfan]

AnimatedMoveViewJob don't overwrite animationEnd

[liuxuan30]

give more details please.

[liuxuan30]

I now understand this.

    internal func animationEnd()
    {
        // Override this
    }

it changed to

    internal func animationEnd()
    {
        fatalError("`animationEnd()` must be overriden by subclasses")
    }

@jjatie Just try ChartsDemo and swipe in the line chart, it will trigger this.

I think we should revert this back to the old implementation here. Not every subclass need to override this, some of them just do nothing. What you think?
adding empty override seems strange, as this is not must-override method.

[jjatie]

I think it would be better to explicitly override it with an empty implementation. Thoughts?

[liuxuan30]

yeah that's where we think differently. asking every subclass to just add an empty override is introducing duplicated code?
Using fatal what I understand is if you don't do that, bad things would happen for sure. But this is not true for the animator? As by default it does nothing at the animation end, but when you want to add something, you can add in subclass then.

[jjatie]

#3099

[liuxuan30]

I already added #3098 :)

[jjatie]

I agree that's the objective-c way to do it. In swift, AnimatedViewPortJob would be a protocol. This is one of those spots where we're kind of stuck between two worlds.

[liuxuan30]

when we are changing to protocol we could change then, like optional

[jjatie]

Yep! That will probably be another year or two though.

[jjatie]

@liuxuan30 by the way. How is 4.0.0 kept up to date. Would it be appropriate for me to PR master into 4.0.0?

[liuxuan30]

It's a headache, as more and more PRs coming to both master and 4.0.
one way is to let git mark the conflicts and we solve it once and for all. Or keep merging master into 4.0, and solve every conflict. Seems both are headaches.
Will get you being able to pushing to 4.0 directly make it easier?

[jjatie]

I don't mind solving the merge conflicts every so often. I think it will be easier to do it periodically, than all at once at the end. I guess I will PR when I think the diff is becoming too big.

[liuxuan30]

ok. I will try ping daniel if this week passed.