Minor clean-up from own audit #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chauduyphanvu
requested review from
a team,
CB-RyanMcCormick,
bichenwang and
cb-jpadilla
and removed request for
a team
cb-jpadilla
reviewed
Sep 8, 2023
chartboostcore/build/outputs/logs/manifest-merger-debug-report.txt
Outdated
Show resolved
Hide resolved
cb-jpadilla
approved these changes
Sep 8, 2023
bichenwang
reviewed
Sep 12, 2023
| dependencies { | ||
| // TODO: Use production. | ||
| implementation 'com.chartboost:chartboost-core-sdk:2023.07.27.1690452723-nightly' | ||
| implementation 'com.chartboost:chartboost-core-sdk:0.2.0' |
| public static final String BUILD_TYPE = "debug"; | ||
| // Field from default config. | ||
| public static final String CHARTBOOST_CORE_VERSION = "0.1.0"; | ||
| public static final String CHARTBOOST_CORE_VERSION = "0.2.0"; |
There was a problem hiding this comment.
isn't this file supposed to get gitignored?
CB-RyanMcCormick
approved these changes
Sep 12, 2023
bichenwang
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/