Skip to content

Add /sources#34

Open
Sleezly wants to merge 11 commits intoCharlesBlonde:masterfrom
Sleezly:master
Open

Add /sources#34
Sleezly wants to merge 11 commits intoCharlesBlonde:masterfrom
Sleezly:master

Conversation

@Sleezly
Copy link
Copy Markdown

@Sleezly Sleezly commented Dec 26, 2018

Hi folks,

This pull request adds the ability to query SoundTouch devices for a list of available sources via GET /sources API lookup. Info on that is here:
https://developer.bose.com/guides/bose-soundtouch-api/bose-soundtouch-api-reference -> (GET) sources

Since not all SoundTouch devices support AUX, this addition allows us to use /sources to build a list of sources available per device and to to check for source status (READY/UNAVAILABLE).

If there's interest in taking this PR, I can add unit tests.

If and once approved, I'll send a corresponding pull-request for HomeAssistant to update to the latest libsoundtouch version to add source switching support for AUX and Bluetooth.

Feedback is welcome.

Thank you for your time!

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-4.1%) to 94.109% when pulling dec128d on Sleezly:master into 25163a7 on CharlesBlonde:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-4.1%) to 94.109% when pulling dec128d on Sleezly:master into 25163a7 on CharlesBlonde:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 26, 2018

Coverage Status

Coverage decreased (-4.1%) to 94.109% when pulling 6756abb on Sleezly:master into 25163a7 on CharlesBlonde:master.

@Sleezly
Copy link
Copy Markdown
Author

Sleezly commented Jan 3, 2019

@CharlesBlonde any chance you can take a look at this pull-request? Please note a number of commits were made to address preexisting failures as Master is now out-of-date with health check tool updates. I'm not sure how to address the python2.7 failure.

Thank you for your time!

@bartbosch
Copy link
Copy Markdown

Hi,

Could the optical option also be added?

Greats, Bart van den Bosch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants