Alternative algorithm for syncing #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- increases robustness
- if the first search doesn't yield the right scene, it keeps searching - switches between searching upwards and downwards - searches until matching scene is found or maxOffset it reached - needs some more polish
- removed a few options and cli arguments
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a second algorithm for finding the offset between the two videos, based on scene changes (two very distinct frames) instead of a single frame.
This should be much more robust, but can potentially take a very long time.
The new algorithm doesn't support all of the "old" flags, and vice versa. Most flags should be supported though (if it makes sense to change them).
Independently of the used algorithm, the found offset will now be checked against multiple positions in the video in order to detect warped videos (slightly slowed down or sped up). One can only tell that a video is warped when letting a non-warped version run in parallel, or after trying to synch in an audio track.
This new feature will warn the user if one of the videos is slower or faster than the other (which causes the offset to be more and more incorrect with increased distance from the initial search position), and will prompt them if they want to continue merging.
In the future, the tool could also try to un-warp the video, but that would be a lot of work and there's no way to tell which of the two videos is the warped one, and which has the original speed.