fix(kanban): harden dispatch cleanup and fresh triage selection - #2
ChanPark03 wants to merge 2 commits into
Conversation
…lity docs The reset keywords have existed in both CLI and gateway handlers since June but were undocumented — users couldn't find how to cancel a personality overlay. Adds a 'Resetting to the default' section to the personality feature page and mentions the reset in the CLI guide, slash-command reference (both tables), and messaging command table.
|
Closed as an accidental fork-to-fork PR. The upstream replacement is NousResearch#77961. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 197ce4ff3e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | `/new` or `/reset` | Start a fresh conversation | | ||
| | `/model [provider:model]` | Show or change the model (supports `provider:model` syntax) | | ||
| | `/personality [name]` | Set a personality | | ||
| | `/personality [name]` | Set a personality (`none` to reset) | |
There was a problem hiding this comment.
Handle reset before rejecting an empty personality catalog
In messaging sessions whose raw config has no agent.personalities entries, /personality none does not reset anything: gateway/slash_commands.py returns personality.none_configured at lines 2507-2508 before reaching the reset branch at lines 2532-2541. This includes users who set agent.system_prompt directly or removed their custom personality catalog, so the newly documented command leaves the overlay active; move the reset handling ahead of the empty-catalog guard or qualify the documentation.
Useful? React with 👍 / 👎.
Recreates the closed NousResearch#69036 change on the restored fork, rebased onto current
main.Original PR: NousResearch#69036
Verification:
pytest -q tests/hermes_cli/test_kanban_db.py tests/hermes_cli/test_kanban_decompose.py tests/gateway/test_kanban_watchers_mixin.py(47 passed).