Added a python snippet to check if a number is an Armstrong number #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
ArifShariar
reviewed
Sep 16, 2023
snippets/python/s/is-armstrong.md
Outdated
| ```py | ||
| def is_armstrong(num): | ||
| copy = num | ||
| Sum = 0 |
There was a problem hiding this comment.
Not mandatory, but I think it is better if you follow the same naming convention all over the Python snippet. All the other variables in the snippet start with smaller case letters, without "Sum". So, it will be better if you rename this variable "sum".
There was a problem hiding this comment.
Hey, thanks for your feedback. But I used 'Sum' because 'sum' is an inbuilt function in python so it would be a bad practice even though it supports it. Maybe I should consider changing the variable name to total/result.
|
Thanks for contributing, but Armstrong number check has been brought up in the past and isn't really relevant to a lot of users, while also being trivial to compute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.