(WIP)perf(state-transition): use native PTC sampling - #9903
Draft
GrapeBaBa wants to merge 2 commits into
Draft
Conversation
Contributor
Performance Report鉁旓笍 no performance regression detected Full benchmark results
|
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #9771.
Gloas and Heze
sanity/slots/pyspec_tests/historical_accumulatorspend most of their time computing 256 epochs of PTC weighted selections. This PR moves the whole-epoch sampler to the Zig native shuffle binding from ChainSafe/lodestar-z#563.Depends on ChainSafe/lodestar-z#563.
Changes
computePtcIndicesForEpochonce per epoch with the existing flat shufflingUint32ArrayresultsptcWindowSSZ child views instead of rebuilding all three epochsHashComputationGroupPerformance
Mainnet preset, consensus-specs v1.7.0-alpha.14, Node 25.2.1:
Focused profiling reduced cumulative
processPtcWindowtime from about 12.27s to 1.04s over 256 epochs. The final state root is unchanged.