fix(builder): catch transient failures on getStateBuilders - #9868
Merged
nflaig merged 3 commits intoAug 20, 2026
Merged
Conversation
nflaig
reviewed
Aug 20, 2026
| logger.warn("Failed to fetch builder", {message: e.message}); | ||
| return null; | ||
| } | ||
| throw e; |
Member
There was a problem hiding this comment.
what kind of errors do we wanna throw here?
Member
There was a problem hiding this comment.
so it's just if pubkey and index mismatch, I suppose
Contributor
Author
There was a problem hiding this comment.
ErrorAborted, builderRes.value() Api errors and FetchError with type "input"
github-project-automation
Bot
moved this from In Progress
to Done
in Lodestar Team Coordination
This was referenced Aug 24, 2026
[REVIEW-01] Close the #9781 foundation review and lifecycle implementation
krisoshea-eth/lodestar#47
Open
Closed
Member
|
馃帀 This PR is included in v1.47.0 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@nflaig noticed and reported builder throwing on
getStateBuildersrequest timeout.Goal of this PR is to catch transient failures, like request timeouts, on
getStateBuilderscalls.Description
Handles timeout error and certain kinds of a fetch error as transient failures, letting the fetching process continue.
Contains tests proving that new handling works.
AI Assistance Disclosure
Used Claude to discuss potential solutions, partially help with tests and audit changes.