feat(builder): add metrics to builder client - #9848
Conversation
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44d7e415ad
鈩癸笍 About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
|
checked the failings, should be fixed with a re-run |
|
@lodekeeper can you investigate why unit tests are flaky https://github.com/ChainSafe/lodestar/actions/runs/32237943058/job/96025727362?pr=9848, was there a regression we introduced recently? it seems quite common in the last few days for those to run into a timeout |
|
@nflaig I checked the linked job and nearby failures. The linked unit failure is attempt 2 job The pattern is not #9848-specific: recent unrelated branches hit the same family ( The remaining red on current #9848 is the separate e2e bucket: Likely hardening: isolate or raise timeout for the perf-state unit tests (or reduce the fixture/cache cost), and make the child-process e2e cleanup use a bounded kill fallback / longer hook timeout. I haven't found a deterministic recent regression to blame yet. |
|
馃帀 This PR is included in v1.47.0 馃帀 |
Motivation
Metrics setup.
Description
Additions and notes:
bc_as a metric prefix, avoiding collision withlodestar_builder_in beacon node metrics, and aligned withvc_on validator.Verified with Kurtosis dev environment setup.
AI Assistance Disclosure
Used Claude to check the repo for existing patterns and audit changes. All changes authored manually.