feat: use zig backed lodestar-z shuffle - #9829
Open
nazarhussain wants to merge 2 commits into
Open
Conversation
nazarhussain
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c3cfb0d97
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| nodeLinker: isolated | ||
|
|
||
| catalog: | ||
| "@chainsafe/lodestar-z": "github:ChainSafe/lodestar-z#nh/swap-or-not-shuffle-parity" |
There was a problem hiding this comment.
When @lodestar/state-transition is packed or published, pnpm replaces its catalog: dependency with this catalog value, so downstream users receive the mutable nh/swap-or-not-shuffle-parity branch rather than the commit recorded in this repository's lockfile. A later branch update could therefore change consensus-critical native shuffling code without a Lodestar change or lockfile review. Use the resolved commit hash or a released package version in the catalog.
Useful? React with 👍 / 👎.
Contributor
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
twoeths
reviewed
Aug 17, 2026
twoeths
left a comment
twoeths
left a comment
Member
There was a problem hiding this comment.
need to wait for a @chainsafe/lodestar-z release
nazarhussain
added a commit
to ChainSafe/lodestar-z
that referenced
this pull request
Aug 19, 2026
Review feedback: the async variants are unused (ChainSafe/lodestar#9829 calls unshuffleList, computeProposerIndex and computeSyncCommitteeIndices), so drop asyncShuffleList/asyncUnshuffleList and the async_task helper -- the zapi AsyncTask work waits for a future release. Also unbind the other unused package exports (forward shuffleList, ComputeShuffledIndex, the Electra wrappers, SHUFFLE_ROUNDS_* and ByteCount); the Zig module still implements them, so re-binding later is a few lines. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
nazarhussain
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Migrate shuffling to the new zig-based implementation from ChainSafe/lodestar-z#559, removing the rust-based
@chainsafe/swap-or-not-shuffledependency.Description
@chainsafe/lodestar-z(pinned via pnpm catalog) and remove@chainsafe/swap-or-not-shufflefrom state-transition and beacon-nodeunshuffleList/asyncUnshuffleList/computeProposerIndex/computeSyncCommitteeIndicescall sites tobindings.shuffle— API is identical, no logic changesVerified with build, check-types, lint, state-transition unit tests, and a shuffle/unshuffle roundtrip smoke test.
🤖 AI-assisted (Claude Code)