chore: reject blob sidecar with slot not higher than parent - #9740
Conversation
There was a problem hiding this comment.
thanks @Alleysira, this is known, I have a branch where this is already fixed, I am happy to merge this one, but that code is effectively unused. I would probably remove the unit test though, since in #9372 we wire up gossip validation spec tests that also caught this problem. I really appreciate you opening these PRs and looking after lodestar 鉂わ笍
The gossip validator classified a blob sidecar whose slot is <= its known parent's slot as IGNORE, but the Deneb p2p spec requires REJECT (validate_gossip_blob_sidecar). The data-column sidecar path already uses REJECT for the same condition.
|
Thanks for your quick response! @nflaig Good to hear it's already caught. Will drop the unit test and happy to help :) |
7b14c94 to
dee376d
Compare
nflaig
changed the title
nflaig
left a comment
nflaig
left a comment
There was a problem hiding this comment.
@Alleysira awesome, I renamed the title to chore since there is no live network anymore that is on deneb, but this is a nice find, curious how you found it
|
Cool. It came out of differential-testing the CL clients' gossip validation against the spec. I was walking each |
|
馃帀 This PR is included in v1.46.0 馃帀 |
3 participants
Motivation
Fix a blob sidecar gossip validation spec violation.
Description
Closes #9738
NOT_LATER_THAN_PARENThandling fromignoretorejectblobSidecar.test.ts, passedAI Assistance Disclosure
Used claude to help draft the regression test.