feat: allow multiple bids compatible with the head view - #9739
Merged
Conversation
Contributor
Performance Report鉁旓笍 no performance regression detected Full benchmark results
|
nflaig
commented
Jul 31, 2026
Comment on lines
463
to
467
| case GossipType.execution_payload_bid: { | ||
| // instead of searching for the message root, this searches for the parent root | ||
| // Search for the parent independently of current head compatibility. A bid may arrive | ||
| // before its parent block, so compatibility is checked later during gossip validation. | ||
| const parentBlockRoot = getParentBlockRootFromSignedExecutionPayloadBidSerialized(message.msg.data); | ||
| const parentBlockHash = getParentBlockHashFromSignedExecutionPayloadBidSerialized(message.msg.data); |
Member
Author
There was a problem hiding this comment.
@twoeths @wemeetagain curious what are your thoughts about queuing bids in the network processor, I think this could be a potential dos vector
Member
There was a problem hiding this comment.
the root cause is epoch transition when validating gossip bid
I guess it's not an issue once we have #9739
that would prevent the epoch transition when validating the bid
so we can still run epoch transition when validating bid with this PR
we can avoid that by also front-running epoch transition for parent as well
but that means 2 epoch transition per epoch which affects us heavily
Member
Author
There was a problem hiding this comment.
but that means 2 epoch transition per epoch which affects us heavily
we should disallow this to happen at the epoch boundary somehow, currently the proposer boost reorg spec also prevents this behavior via is_not_at_epoch_boundary, so if we are proposer or others following the spec as is will not use bids for the parent of our head
wemeetagain
reviewed
Jul 31, 2026
nflaig
commented
Jul 31, 2026
twoeths
reviewed
Aug 1, 2026
| forkChoice: IForkChoice, | ||
| head: ProtoBlock, | ||
| bidSlot: Slot, | ||
| parentBlockRoot: RootHex, |
Member
There was a problem hiding this comment.
maybe bidParentBlockRoot and bidParentBlockHash would makes it easier to understand
Member
Author
There was a problem hiding this comment.
applied that naming more broadly. I think it make sense to avoid confusing
spiral-ladder
approved these changes
Aug 3, 2026
Member
Author
|
review comments have been addressed, gonna merge this to prepare for |
twoeths
approved these changes
Aug 3, 2026
markolazic01
pushed a commit
to markolazic01/lodestar
that referenced
this pull request
Aug 3, 2026
implements ethereum/consensus-specs#5497 - Restricts propagation to bids compatible with the local head view - Tracks seen bids per builder and parent tuple - Preserves recovery for bids received before their parent block - Prevents duplicate validation before regeneration and after signature verification
This was referenced Aug 3, 2026
nflaig
added a commit
that referenced
this pull request
Aug 4, 2026
Follow-up to #9739 Ignore bids building on the head parent at epoch boundaries, since proposer-boost reorgs are disabled and validating them would regenerate an unusable parent state through the epoch transition.
Member
|
馃帀 This PR is included in v1.46.0 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements ethereum/consensus-specs#5497