Skip to content

chore: review eip-7688 branch - #9671

Merged
twoeths merged 3 commits into
eip-7688from
te/eip-7688_progressive_utils
Jul 17, 2026
Merged

chore: review eip-7688 branch#9671
twoeths merged 3 commits into
eip-7688from
te/eip-7688_progressive_utils

Conversation

@twoeths

@twoeths twoeths commented Jul 17, 2026

Copy link
Copy Markdown
Member

Description

  • more progressive ssz utils to reuse nodes, this improves:
    • gloas fork transition to migrate basic list
    • progressParticipationFlagUpdates, which happens at epoch transition
  • also do not check deposit length as found in feat: implement EIP 7688聽#9390 (comment)

AI Assistance Disclosure

  • created with the help of Claude

@twoeths
twoeths requested a review from a team as a code owner July 17, 2026 08:17

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request optimizes state transitions and upgrades to the Gloas fork by introducing efficient progressive list migrations and zero-filled node initializations, significantly reducing re-merkleization overhead. Specifically, it updates participation flag updates to use pre-computed zero nodes and refactors state upgrades to reuse existing basic and composite list nodes. The review feedback correctly identifies TypeScript compilation errors in upgradeStateToGloas.ts where fuluList.node (typed as Node) is accessed via .left without being cast to BranchNode. Implementing the suggested casts and importing BranchNode will resolve these compilation issues.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/state-transition/src/slot/upgradeStateToGloas.ts
Comment thread packages/state-transition/src/slot/upgradeStateToGloas.ts
Comment thread packages/state-transition/src/slot/upgradeStateToGloas.ts
@twoeths

twoeths commented Jul 17, 2026

Copy link
Copy Markdown
Member Author

re-reviewed myself, merging to the eip-7688 branch now

@twoeths
twoeths merged commit feb2570 into eip-7688 Jul 17, 2026
16 checks passed
@twoeths
twoeths deleted the te/eip-7688_progressive_utils branch July 17, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant