Skip to content

fix: IGNORE not REJECT on bid fee_recipient mismatch - #9610

Merged
ensi321 merged 2 commits into
nc/alpha.12from
nc/alpha.12-bid-fee-recipient-ignore
Jul 7, 2026
Merged

fix: IGNORE not REJECT on bid fee_recipient mismatch #9610
ensi321 merged 2 commits into
nc/alpha.12from
nc/alpha.12-bid-fee-recipient-ignore

Conversation

@ensi321

@ensi321 ensi321 commented Jul 7, 2026

Copy link
Copy Markdown
Member

…5429)

Gossip verdict for bid.fee_recipient != proposer_preferences.fee_recipient
changed from REJECT to IGNORE per consensus-specs #5429.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ensi321
ensi321 requested a review from a team as a code owner July 7, 2026 06:24

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the validation logic for execution payload bids in executionPayloadBid.ts. Specifically, when there is a mismatch between the bid's fee recipient and the proposer's preferences, the gossip action is changed from REJECT to IGNORE, aligning with consensus-specs #5429. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@ensi321
ensi321 merged commit e3379af into nc/alpha.12 Jul 7, 2026
2 of 3 checks passed
@ensi321
ensi321 deleted the nc/alpha.12-bid-fee-recipient-ignore branch July 7, 2026 06:25
ensi321 added a commit that referenced this pull request Jul 21, 2026
ethereum/consensus-specs#5429

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant