Skip to content

fix(beacon-node): cast emitter at the failing emit site to fix tsgo overload #9491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nflaig merged 1 commit into from
Jun 9, 2026
Merged

fix(beacon-node): cast emitter at the failing emit site to fix tsgo overload #9491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/beacon-node/test/unit/sync/unknownBlock.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,7 +1020,9 @@ describe("UnknownBlockSync", () => {
emitter.emit(routes.events.EventType.block, {slot: 1, block: blockRootHex, executionOptimistic: false});
});

emitter.emit(ChainEvent.unknownEnvelopeBlockRoot, {
// tsgo overload-resolution miss when emit is reached through a closure that captures emitter
// first; cast re-anchors the StrictEventEmitter overload for ChainEvent keys.
(emitter as ChainEventEmitter).emit(ChainEvent.unknownEnvelopeBlockRoot, {
rootHex: blockRootHex,
slot: 0,
peer,
Expand Down
Loading