Skip to content

chore: pluralize gloas execution payload endpoint paths #9440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nflaig merged 2 commits into from
Jun 1, 2026
Merged

chore: pluralize gloas execution payload endpoint paths #9440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d499b8c
chore: pluralize gloas execution payload endpoint paths
nflaig Jun 1, 2026
9bec7c3
more renaming
nflaig Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/api/src/beacon/routes/beacon/block.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ export function getDefinitions(config: ChainForkConfig): RouteDefinitions<Endpoi
},
},
publishExecutionPayloadEnvelope: {
url: "/eth/v1/beacon/execution_payload_envelope",
url: "/eth/v1/beacon/execution_payload_envelopes",
method: "POST",
req: {
writeReqJson: ({signedExecutionPayloadEnvelope}) => {
Expand Down Expand Up @@ -661,7 +661,7 @@ export function getDefinitions(config: ChainForkConfig): RouteDefinitions<Endpoi
},
},
publishExecutionPayloadBid: {
url: "/eth/v1/beacon/execution_payload_bid",
url: "/eth/v1/beacon/execution_payload_bids",
method: "POST",
req: {
writeReqJson: ({signedExecutionPayloadBid}) => {
Expand Down Expand Up @@ -705,7 +705,7 @@ export function getDefinitions(config: ChainForkConfig): RouteDefinitions<Endpoi
},
},
getSignedExecutionPayloadEnvelope: {
url: "/eth/v1/beacon/execution_payload_envelope/{block_id}",
url: "/eth/v1/beacon/execution_payload_envelopes/{block_id}",
Comment thread
nflaig marked this conversation as resolved.
method: "GET",
req: blockIdOnlyReq,
resp: {
Expand Down
2 changes: 1 addition & 1 deletion packages/api/src/beacon/routes/validator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,7 +960,7 @@ export function getDefinitions(config: ChainForkConfig): RouteDefinitions<Endpoi
},
},
getExecutionPayloadEnvelope: {
url: "/eth/v1/validator/execution_payload_envelope/{slot}/{beacon_block_root}",
url: "/eth/v1/validator/execution_payload_envelopes/{slot}/{beacon_block_root}",
method: "GET",
req: {
writeReq: ({slot, beaconBlockRoot}) => ({
Expand Down
12 changes: 6 additions & 6 deletions packages/api/test/unit/beacon/oapiSpec.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {testData as validatorTestData} from "./testData/validator.js";
// Solutions: https://stackoverflow.com/questions/46745014/alternative-for-dirname-in-node-js-when-using-es6-modules
const __dirname = path.dirname(fileURLToPath(import.meta.url));

const version = "v5.0.0-alpha.1";
const version = "v5.0.0-alpha.2";
const openApiFile: OpenApiFile = {
url: `https://github.com/ethereum/beacon-APIs/releases/download/${version}/beacon-node-oapi.json`,
filepath: path.join(__dirname, "../../../oapi-schemas/beacon-node-oapi.json"),
Expand Down Expand Up @@ -52,15 +52,12 @@ const testDatas = {
};

const ignoredOperations = [
/* missing route */
"getDepositSnapshot", // Won't fix for now, see https://github.com/ChainSafe/lodestar/issues/5697
"getNextWithdrawals", // https://github.com/ChainSafe/lodestar/issues/5696
// TODO GLOAS: not yet implemented
"getExecutionPayloadBid",
"getSignedExecutionPayloadEnvelope",
];

const ignoredProperties: Record<string, IgnoredProperty> = {
/*
/*
https://github.com/ChainSafe/lodestar/issues/6168
/query/syncing_status - must be integer
*/
Expand All @@ -74,6 +71,9 @@ const ignoredTopics: string[] = [
// TODO GLOAS: required by v5.0.0-alpha.1
"payload_attestation_message",
"execution_payload_bid",
// TODO: not yet implemented, added in v5.0.0-alpha.2
"head_v2",
"fast_confirmation",
];

// eventstream types are defined as comments in the description of "examples".
Expand Down
Loading