feat: force the proposer to reorg late payloads - #9431
Merged
Conversation
…ld-on-full-slot-guard # Conflicts: # packages/fork-choice/test/unit/protoArray/gloas.test.ts
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the shouldBuildOnFull method in ProtoArray to force building on the EMPTY variant if the payload is determined to be untimely, in addition to when blob data is unavailable. Unit tests have been added to verify this behavior under threshold conditions. There are no review comments, so no additional feedback is provided.
nflaig
marked this pull request as draft
May 31, 2026 11:12
Base automatically changed from
nflaig/should-build-on-full-slot-guard
to
unstable
May 31, 2026 13:21
# Conflicts: # packages/beacon-node/src/chain/produceBlock/produceBlockBody.ts # packages/fork-choice/src/protoArray/protoArray.ts # packages/fork-choice/test/unit/protoArray/gloas.test.ts
nflaig
marked this pull request as ready for review
May 31, 2026 13:30
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19909e2614
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // signalled the blob data is not available, forcing a build on EMPTY (reorg). | ||
| // (set by chain.getProposerHead(slot)). Returns false when the PTC majority signalled | ||
| // the blob data is not available or the payload was not timely, forcing a build on EMPTY (reorg). | ||
| const isBuildingOnFull = this.forkChoice.shouldBuildOnFull(parentBlock, blockSlot); |
There was a problem hiding this comment.
When a Gloas proposer has a builder bid for the FULL head and PTC timeliness NO votes exceed the threshold, this new shouldBuildOnFull check only affects the local execution-payload branch. The earlier builderBid !== undefined branch never calls it, and produceBlockV4 fetches a bid for parentBlock.executionPayloadBlockHash then prefers any fulfilled builder result, so the validator can still publish a builder block extending the late FULL payload instead of reorging to EMPTY. The builder path needs to be gated or look up/build only bids for the EMPTY parent when shouldBuildOnFull(parentBlock, slot) is false.
Useful? React with 👍 / 👎.
Member
Author
There was a problem hiding this comment.
this new shouldBuildOnFull check only affects the local execution-payload branch
this seems like a bug if that's the case, but kinda unrelated to this PR
Member
Author
There was a problem hiding this comment.
cc @ensi321 since you worked on this, I haven't reviewed your PR in detail yet but this seems like a valid finding, meaning we would not reorg late payloads if we use a bid instead of local build
Member
There was a problem hiding this comment.
It's a valid concern. We need to call shouldBuildOnFull in our builder bid flow
Member
Author
There was a problem hiding this comment.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
reviewed
Jun 1, 2026
twoeths
left a comment
twoeths
left a comment
Member
There was a problem hiding this comment.
the change itself is correct, just want to compare to FULL variant instead
twoeths
approved these changes
Jun 1, 2026
Member
|
🎉 This PR is included in v1.44.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ethereum/consensus-specs#5210, depends on #9428