chore: rename ptcVotes to payloadTimelinessVotes - #9424
Merged
nflaig merged 4 commits intoMay 30, 2026
Merged
Conversation
Align the private field name with the gloas fork-choice spec, which calls this store entry `payload_timeliness_vote` (companion to the existing `payload_data_availability_vote` tracked by `daVotes`). Pure rename — no behavior change. Unit tests pass (80/80 in `packages/fork-choice/test/unit/protoArray/gloas.test.ts`). The public `getPTCVotes()` API and the spec-comment references are unchanged. 🤖 Generated with AI assistance
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames the private property ptcVotes to payloadTimelinessVotes in the ProtoArray class to improve clarity, updating all its references and associated test comments. There are no review comments, and I have no feedback to provide.
nflaig
previously approved these changes
May 30, 2026
nflaig
reviewed
May 30, 2026
Mirror the `ptcVotes` → `payloadTimelinessVotes` rename so the second PTC vote map also matches its spec name. The gloas store entry is `payload_data_availability_vote`, parallel to `payload_timeliness_vote`. Local variables (`const daVotes = this.payloadDataAvailabilityVotes…`) are kept short — same pattern as `const votes` aliasing the timeliness map in `notifyPtcMessages`/`isPayloadTimely`/etc. Pure rename — no behavior change. `pnpm check-types` + biome clean, 80/80 gloas protoArray tests pass. 🤖 Generated with AI assistance
nflaig
reviewed
May 30, 2026
`ptcAttested` was the odd one out after the previous renames: it tracks which PTC members have voted at all (any payload_status), not a specific vote value, so "Attested" was imprecise. `ptcParticipation` captures the intent (presence/membership tracking) without implying a vote direction. 🤖 Generated with AI assistance
nflaig
reviewed
May 30, 2026
Per nflaig review on r3328590550, keep the previous `ptcAttested` name. The earlier rename to `ptcParticipation` was a follow-up suggestion; nflaig prefers the original. 🤖 Generated with AI assistance
nflaig
changed the title
Member
that suffices, merging |
Member
|
🎉 This PR is included in v1.44.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Align the private field name in
ProtoArraywith the gloas fork-choice spec, which calls this store entrypayload_timeliness_vote. The companion field for blob-data availability is already tracked via the existingdaVotesmap.This was the last unmerged piece of lodekeeper#8 — the data-availability tracking landed independently in #9416 and force-reorg in #9387, so only the rename is left.
Changes
packages/fork-choice/src/protoArray/protoArray.ts: renameprivate ptcVotes→private payloadTimelinessVotesand all 6 in-class references.packages/fork-choice/test/unit/protoArray/gloas.test.ts: update 2 comments that reference the old field name.Pure rename — no behavior change. Public
getPTCVotes()API,isPayloadTimely/isPayloadNotTimely, and surrounding spec comments are unchanged.Verification
pnpm check-typesclean inpackages/fork-choice.pnpm biome checkclean on the two touched files.vitest run test/unit/protoArray/gloas.test.ts→ 80/80 pass.🤖 Generated with AI assistance