Skip to content

chore: index proposer preferences by slot first #9312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nflaig merged 2 commits into from
Apr 30, 2026
Merged

chore: index proposer preferences by slot first #9312

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc8bcec
chore: index proposer preferences by slot first
markolazic01 Apr 30, 2026
fa68f3a
chore: use keys() instead of entries() in prune
markolazic01 Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions packages/beacon-node/src/chain/seenCache/seenProposerPreferences.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,16 @@ import {MapDef} from "@lodestar/utils";
* Tracks signed proposer preferences we've already seen per (dependent_root, proposal_slot, validator_index).
*/
export class SeenProposerPreferences {
private readonly validatorBySlotByDependentRoot = new MapDef<RootHex, Map<Slot, ValidatorIndex>>(
() => new Map<Slot, ValidatorIndex>()
private readonly validatorByDependentRootBySlot = new MapDef<Slot, Map<RootHex, ValidatorIndex>>(
() => new Map<RootHex, ValidatorIndex>()
);

isKnown(dependentRoot: RootHex, proposalSlot: Slot, validatorIndex: ValidatorIndex): boolean {
return this.validatorBySlotByDependentRoot.get(dependentRoot)?.get(proposalSlot) === validatorIndex;
return this.validatorByDependentRootBySlot.get(proposalSlot)?.get(dependentRoot) === validatorIndex;
}

add(dependentRoot: RootHex, proposalSlot: Slot, validatorIndex: ValidatorIndex): void {
this.validatorBySlotByDependentRoot.getOrDefault(dependentRoot).set(proposalSlot, validatorIndex);
this.validatorByDependentRootBySlot.getOrDefault(proposalSlot).set(dependentRoot, validatorIndex);
}

/**
Expand All @@ -23,14 +23,9 @@ export class SeenProposerPreferences {
* on each slot tick.
*/
prune(currentSlot: Slot): void {
for (const [dependentRoot, slotMap] of this.validatorBySlotByDependentRoot.entries()) {
for (const slot of slotMap.keys()) {
if (slot < currentSlot) {
slotMap.delete(slot);
}
}
if (slotMap.size === 0) {
this.validatorBySlotByDependentRoot.delete(dependentRoot);
for (const slot of this.validatorByDependentRootBySlot.keys()) {
if (slot < currentSlot) {
this.validatorByDependentRootBySlot.delete(slot);
}
}
}
Expand Down
Loading