feat: wire up proposer_preferences gossip topic - #9275
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d817b4893f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements the ProposerPreferences gossip topic and validation logic for the Gloas fork. It introduces a SeenProposerPreferences cache, error types, and signature verification routines. The feedback identifies a performance optimization in the validation flow to avoid unnecessary state fetches for duplicate messages and suggests increasing the expectedMessageRate in gossip scoring to accurately reflect network activity.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
marked this pull request as draft
April 24, 2026 22:30
nflaig
marked this pull request as ready for review
April 24, 2026 22:35
ensi321
previously approved these changes
Apr 24, 2026
ensi321
left a comment
ensi321
left a comment
Member
There was a problem hiding this comment.
Not fully reviewed but this is low risk to merge
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5a3f03a30
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
Author
|
going to merge this into |
wemeetagain
approved these changes
Apr 25, 2026
wemeetagain
left a comment
wemeetagain
left a comment
Member
There was a problem hiding this comment.
lgtm, everything looks good
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #9275 +/- ##
=========================================
Coverage 52.58% 52.58%
=========================================
Files 848 848
Lines 61136 61136
Branches 4505 4505
=========================================
Hits 32147 32147
Misses 28925 28925
Partials 64 64 🚀 New features to boost your workflow:
|
nflaig
commented
Apr 25, 2026
| ] = getTopicScoreParams(config, precomputedParams, { | ||
| topicWeight: PROPOSER_PREFERENCES_WEIGHT, | ||
| // Upper bound ~64 messages per epoch: one per proposer across the current + next epoch. | ||
| expectedMessageRate: 64 / SLOTS_PER_EPOCH, |
Member
Author
There was a problem hiding this comment.
could be more if there is a epoch boundary reorg which causes dependent root to change but this also depends on how clients will broadcast these, either way this seems fine
nflaig
commented
Apr 25, 2026
| dropOpts: {type: DropType.count, count: 1}, | ||
| }, | ||
| [GossipType.proposer_preferences]: { | ||
| maxLength: 1024, |
Member
Author
There was a problem hiding this comment.
this queue is likely way too long but not sure that really matters much
Member
|
🎉 This PR is included in v1.43.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.