Skip to content

fix: process fulu data columns without waiting for block #9166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nflaig wants to merge 2 commits into from
Closed

fix: process fulu data columns without waiting for block #9166

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea28fb7
fix: process fulu data columns without waiting for block
nflaig Apr 3, 2026
685e97f
Do not throw
nflaig Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/beacon-node/src/network/processor/extractSlotRootFns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import {ForkName, ForkSeq} from "@lodestar/params";
import {SlotOptionalRoot, SlotRootHex} from "@lodestar/types";
import {
getBeaconBlockRootFromDataColumnSidecarSerialized,
getBeaconBlockRootFromFuluDataColumnSidecarSerialized,
getBlockRootFromBeaconAttestationSerialized,
getBlockRootFromPayloadAttestationMessageSerialized,
getBlockRootFromSignedAggregateAndProofSerialized,
Expand Down Expand Up @@ -65,7 +66,8 @@ export function createExtractBlockSlotRootFns(): ExtractSlotRootFns {
}

if (ForkSeq[fork] < ForkSeq.gloas) {
return {slot};
const root = getBeaconBlockRootFromFuluDataColumnSidecarSerialized(data);
return root !== null ? {slot, root} : {slot};
}

const root = getBeaconBlockRootFromDataColumnSidecarSerialized(data);
Expand Down
6 changes: 6 additions & 0 deletions packages/beacon-node/src/network/processor/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,12 @@ export class NetworkProcessor {
preprocessResult = {action: PreprocessAction.PushToQueue};
}

if (topicType === GossipType.data_column_sidecar && ForkSeq[fork] < ForkSeq.gloas) {
// Fulu sidecar validation only needs the parent block/state, not the block referenced by the sidecar itself.
// Trigger unknown block sync above, but continue validation without waiting for the full block.
preprocessResult = {action: PreprocessAction.PushToQueue};
}

if (ForkSeq[fork] >= ForkSeq.gloas) {
// specific check for each topic
// note that it's supposed to NOT queue beacon_block (handled above) and execution_payload because it's not a one-off;
Expand Down
17 changes: 17 additions & 0 deletions packages/beacon-node/src/util/sszBytes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,7 @@ export function getSlotFromBlobSidecarSerialized(data: Uint8Array): Slot | null
const SLOT_BYTES_POSITION_IN_SIGNED_DATA_COLUMN_SIDECAR_PRE_GLOAS = 20;
const SLOT_BYTES_POSITION_IN_SIGNED_DATA_COLUMN_SIDECAR_POST_GLOAS = 16;
const BEACON_BLOCK_ROOT_POSITION_IN_GLOAS_DATA_COLUMN_SIDECAR = 24;
const BEACON_BLOCK_HEADER_SIZE = SLOT_SIZE + 8 + ROOT_SIZE + ROOT_SIZE + ROOT_SIZE;

export function getSlotFromDataColumnSidecarSerialized(data: Uint8Array, fork: ForkName): Slot | null {
const offset = isForkPostGloas(fork)
Expand Down Expand Up @@ -551,6 +552,22 @@ export function getBeaconBlockRootFromDataColumnSidecarSerialized(data: Uint8Arr
return "0x" + blockRootBuf.toString("hex");
}

export function getBeaconBlockRootFromFuluDataColumnSidecarSerialized(data: Uint8Array): RootHex | null {
if (data.length < SLOT_BYTES_POSITION_IN_SIGNED_DATA_COLUMN_SIDECAR_PRE_GLOAS + BEACON_BLOCK_HEADER_SIZE) {
return null;
}

const blockHeader = ssz.phase0.BeaconBlockHeader.deserialize(
data.subarray(
SLOT_BYTES_POSITION_IN_SIGNED_DATA_COLUMN_SIDECAR_PRE_GLOAS,
SLOT_BYTES_POSITION_IN_SIGNED_DATA_COLUMN_SIDECAR_PRE_GLOAS + BEACON_BLOCK_HEADER_SIZE
)

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Guard Fulu header parsing against malformed gossip bytes

getBeaconBlockRootFromFuluDataColumnSidecarSerialized() now calls ssz.phase0.BeaconBlockHeader.deserialize(...) directly during the network pre-processing path, but this helper is expected to be non-throwing (all other extractors return null for invalid input). A malformed sidecar with valid length but invalid header encoding can make this deserialize call throw, and onPendingGossipsubMessage does not catch extractor errors, so untrusted gossip can abort processing instead of being handled as invalid gossip. Please wrap this deserialize in a try/catch and return null on parse failure.

Useful? React with 👍 / 👎.

@nflaig nflaig Apr 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is valid, also calling hashTreeRoot() here might be a concern in general since we wanna avoid expensive work

);
const blockRoot = ssz.phase0.BeaconBlockHeader.hashTreeRoot(blockHeader);

@twoeths twoeths Apr 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so now we have to do a hashTreeRoot() here which is not cheap

@nflaig nflaig Apr 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep same concern I had here #9166 (comment), do we just want the change in network process index file?

I guess this becomes unnecessary if we do not extract the root since it's skipped anyways here

lodestar/packages/beacon-node/src/network/processor/index.ts

Line 343 in bc0be71

if (root && !this.chain.forkChoice.hasBlockHexUnsafe(root)) {

if there is no root extracted

blockRootBuf.set(blockRoot);
return `0x${blockRootBuf.toString("hex")}`;
}

/**
* SignedExecutionPayloadEnvelope SSZ Layout:
* ├─ 4 bytes: message offset (points to byte 100)
Expand Down
16 changes: 16 additions & 0 deletions packages/beacon-node/test/unit/util/sszBytes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import {
getAttesterIndexFromSingleAttestationSerialized,
getBeaconBlockRootFromDataColumnSidecarSerialized,
getBeaconBlockRootFromExecutionPayloadEnvelopeSerialized,
getBeaconBlockRootFromFuluDataColumnSidecarSerialized,
getBlobKzgCommitmentsCountFromSignedBeaconBlockSerialized,
getBlockRootFromAttestationSerialized,
getBlockRootFromPayloadAttestationMessageSerialized,
Expand Down Expand Up @@ -57,6 +58,7 @@ import {
getSlotFromSignedExecutionPayloadBidSerialized,
getSlotFromSingleAttestationSerialized,
} from "../../../src/util/sszBytes.js";
import {generateBlockWithColumnSidecars} from "../../utils/blocksAndData.js";
import {generateRandomBlob} from "../../utils/kzg.js";

describe("SinlgeAttestation SSZ serialized picking", () => {
Expand Down Expand Up @@ -611,13 +613,27 @@ describe("DataColumnSidecar SSZ serialized picking (fork-aware)", () => {
});
}

it("getBeaconBlockRootFromFuluDataColumnSidecarSerialized", () => {
const {columnSidecars, rootHex} = generateBlockWithColumnSidecars({forkName: ForkName.fulu});
const bytes = ssz.fulu.DataColumnSidecar.serialize(columnSidecars[0]);

expect(getBeaconBlockRootFromFuluDataColumnSidecarSerialized(bytes)).toBe(rootHex);
});

it("getSlotFromDataColumnSidecarSerialized - invalid data", () => {
// Slot is at offset 20 for pre-Gloas, need at least 28 bytes
const invalidSizes = [0, 10, 27];
for (const size of invalidSizes) {
expect(getSlotFromDataColumnSidecarSerialized(Buffer.alloc(size), ForkName.fulu)).toBeNull();
}
});

it("getBeaconBlockRootFromFuluDataColumnSidecarSerialized - invalid data", () => {
const invalidSizes = [0, 20, 131];
for (const size of invalidSizes) {
expect(getBeaconBlockRootFromFuluDataColumnSidecarSerialized(Buffer.alloc(size))).toBeNull();
}
});
});

describe("Gloas", () => {
Expand Down
Loading