fix: restore seen root dedupe for column created block inputs - #9162
Closed
nflaig wants to merge 1 commit into
Closed
fix: restore seen root dedupe for column created block inputs#9162nflaig wants to merge 1 commit into
nflaig wants to merge 1 commit into
Conversation
Fulu can cache a BlockInput from data columns before the full beacon block is available. PR #9025 narrowed seenBlock() to only treat roots with a cached block as seen, which caused the network processor to start unknownBlockRoot sync for roots that were already being assembled locally from columns. Restore the broader seen-root check for BlockInput cache entries while keeping hasBlock() available for the narrower "full block present" query. Add a regression test covering a Fulu column-first cache entry.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new has method to the SeenBlockInput cache and updates the BeaconChain's seenBlock logic to utilize it. This change ensures that blocks currently being assembled from data columns are recognized as seen, which helps prevent redundant synchronization requests. Additionally, a unit test has been added to verify the behavior for column-only block inputs. I have no feedback to provide as the existing review comments were explanatory and did not identify any issues or areas for improvement.
Contributor
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
twoeths
reviewed
Apr 3, 2026
twoeths
left a comment
twoeths
left a comment
Member
There was a problem hiding this comment.
we need "seenBlock", not "seenBlockHex"
ie we want to know if the chain see an imported beacon_block
so we should keep the current behavior of seenBlock() function
but I do see we have a bug: DataColumnSidecar does not need a BeaconBlock to be validated in its p2p validation rule, we should search for the block, but do not await for it
we should fix it instead
Member
Author
I suppose you mean for fulu? then yes we should definitely not delay column import |
Member
yes, for fulu only |
Member
Author
exactly, I thought the fulu case we already pass through, need to fix that before we cut a rc today |
Member
Author
|
closing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #9162 +/- ##
=========================================
Coverage 52.52% 52.52%
=========================================
Files 848 848
Lines 61447 61447
Branches 4528 4528
=========================================
Hits 32272 32272
Misses 29110 29110
Partials 65 65 🚀 New features to boost your workflow:
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fulu can cache a
BlockInputfrom data columns before the full beacon block is available.PR #9025 narrowed
seenBlock()to only treat roots with a cached block as seen, which caused the network processor to startunknownBlockRootsync for roots that were already being assembled locally from columns.Restore the broader seen root check for
BlockInputcache entries while keepinghasBlock()available for the narrower "full block present" query. Add a regression test covering a Fulu column first cache entry.