fix: process payload attestations before payload envelope import - #9159
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the network processor to stop awaiting the full payload envelope for payload_attestation_message, as only the block is required for processing. It also clarifies documentation regarding messages that require full payload variants. Feedback suggests extending this logic to beacon_attestation and beacon_aggregate_and_proof when they act as PTC votes to ensure consistent behavior across similar message types.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
approved these changes
Apr 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #9159 +/- ##
=========================================
Coverage 52.52% 52.52%
=========================================
Files 848 848
Lines 61447 61447
Branches 4528 4528
=========================================
Hits 32272 32272
Misses 29110 29110
Partials 65 65 🚀 New features to boost your workflow:
|
Member
|
🎉 This PR is included in v1.42.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #9025, there is no need to delay processing payload attestations until the payload envelope is fully imported, the gossip validation and fork choice only require beacon block to be known.
This is mostly problematic because PTC members will cast their vote based on the fact that the payload and all data is available, but not that the payload is valid (as per execution layer) and fully imported.
This timing discrepancy means that it's very likely we receive
payload_attestation_messageon gossip before we have fully imported the corresponding payload and currently this means we would delay re-gossiping and importing these messages for no good reason.