fix: update attestation data index extraction - #9158
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors SSZ byte extraction utilities to clarify the distinction between committee indices and data indices, particularly for post-Electra/Gloas logic where the index field is repurposed. Key changes include renaming existing functions and introducing getDataIndexFromSingleAttestationSerialized along with corresponding unit tests. Feedback suggests making getDataIndexFromSingleAttestationSerialized fork-aware to maintain consistency with other utility functions and ensure robustness across different fork layouts.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
marked this pull request as draft
April 2, 2026 14:39
Member
Author
|
@codex review |
nflaig
marked this pull request as ready for review
April 2, 2026 15:12
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #9158 +/- ##
=========================================
Coverage 52.52% 52.52%
=========================================
Files 848 848
Lines 61447 61447
Branches 4528 4528
=========================================
Hits 32272 32272
Misses 29110 29110
Partials 65 65 🚀 New features to boost your workflow:
|
Member
|
🎉 This PR is included in v1.42.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #9025 to fix attestation data index extraction, currently it seems we extract the committee index but for how we use it (post gloas), we want the
data.indexrelevant code
lodestar/packages/beacon-node/src/network/processor/index.ts
Lines 401 to 405 in e8407e9