fix: libp2p v3 unknown peers - #8960
Merged
Merged
Conversation
Contributor
Summary of ChangesHello @nflaig, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses issues with unknown peers in Libp2p v3 by refining the peer identification and metrics handling within the beacon node. It introduces a specific workaround to prevent an 'identify EOF race' condition during metrics collection and significantly simplifies the internal logic for tracking and identifying peers, leading to a more robust and efficient network layer. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses an issue with identifying peers in libp2p v3. The main change introduces a workaround for a race condition between the metrics collection and the identify protocol by preventing the metrics system from tracking the identify protocol's stream. Additionally, a previous implementation for handling peer identification has been reverted. This simplifies the logic in PeerManager by removing the mechanism for tracking in-flight identify requests and its associated event handlers and tests. The new approach triggers an explicit identify call once a peer is confirmed to be relevant. The changes appear to be consistent and address the described issue.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
Member
Author
|
nflaig
marked this pull request as ready for review
February 25, 2026 10:55
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32930e33a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
wemeetagain
approved these changes
Feb 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #8960 +/- ##
=========================================
Coverage 52.25% 52.26%
=========================================
Files 848 848
Lines 62949 62942 -7
Branches 4643 4643
=========================================
Hits 32897 32897
+ Misses 29985 29978 -7
Partials 67 67 🚀 New features to boost your workflow:
|
lodekeeper
pushed a commit
to lodekeeper/lodestar
that referenced
this pull request
Mar 13, 2026
Squash merged ChainSafe#8958 and reverted ChainSafe#8955. Deployed to `feat1`
Member
|
🎉 This PR is included in v1.41.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Squash merged #8958 and reverted #8955.
Deployed to
feat1