-
-
Notifications
You must be signed in to change notification settings - Fork 478
fix: add backpressure to unfinalized block write queue #8885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
matthewkeil
merged 19 commits into
ChainSafe:unstable
from
lodekeeper:feat/queue-wait-for-space
Feb 11, 2026
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
c832219
feat: add backpressure to unfinalized block write queue
lodekeeper bd1c058
fix: clean up abort listener when waitForSpace resolves
lodekeeper e889d88
fix: prevent thundering herd and abort listener leak in waitForSpace
lodekeeper 5bdc431
chore: reduce unfinalized block write queue from 32 to 16
lodekeeper f609f13
fix: close abort race window in waitForSpace
lodekeeper 7be0147
Align MAX_BLOCK_INPUT_CACHE_SIZE value with DEFAULT_MAX_PENDING_UNFIN…
nflaig 19db4c7
chore: reduce unfinalized block write queue from 16 to 5
lodekeeper 50cfab3
Tweak values and comments
nflaig 0b806fe
Reduce cache size a bit
nflaig 67ee093
Apply suggestion from @nflaig
nflaig cf3c68a
Update packages/beacon-node/src/chain/seenCache/seenGossipBlockInput.ts
nflaig d8947a6
Fix formatting
nflaig 60858e3
Reduce MAX_BLOCK_INPUT_CACHE_SIZE
nflaig d6ede14
call notifySpaceWaiters when dropping jobs
nflaig 632686a
Update MAX_BLOCK_INPUT_CACHE_SIZE with proper rationale for choosing …
nflaig 5cca85d
Bump DEFAULT_MAX_PENDING_UNFINALIZED_BLOCK_WRITES to 16 again
nflaig d69d155
Keep the 'up to' since we already import >64 from gossip
nflaig f79fd26
refactor: use MAX_LOOK_AHEAD_EPOCHS for cache size calculation
lodekeeper 3a0535d
merge: resolve conflict with unstable, combine backpressure + error h…
lodekeeper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.