Skip to content

refactor: use map to lookup combined beacon committee selection for duty #8710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wemeetagain merged 1 commit into from
Dec 31, 2025
Merged

refactor: use map to lookup combined beacon committee selection for duty #8710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions packages/validator/src/services/attestationDuties.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,20 +469,33 @@ export class AttestationDutiesService {

const res = await this.api.validator.submitBeaconCommitteeSelections({selections: partialSelections});

const combinedSelections = res.value();
this.logger.debug("Received combined beacon committee selection proofs", {epoch, count: combinedSelections.length});
const combinedSelections = new Map<ValidatorIndex, routes.validator.BeaconCommitteeSelection>();
for (const selection of res.value()) {
combinedSelections.set(selection.validatorIndex, selection);
}
Comment thread
nflaig marked this conversation as resolved.
this.logger.debug("Received combined beacon committee selection proofs", {epoch, count: combinedSelections.size});

for (const dutyAndProof of duties) {
const {slot, validatorIndex, committeeIndex, committeeLength} = dutyAndProof.duty;
const logCtxValidator = {slot, index: committeeIndex, validatorIndex};

const combinedSelection = combinedSelections.find((s) => s.validatorIndex === validatorIndex && s.slot === slot);
const combinedSelection = combinedSelections.get(validatorIndex);

if (!combinedSelection) {
this.logger.debug("Did not receive combined beacon committee selection proof", logCtxValidator);
continue;
}

if (combinedSelection.slot !== slot) {
this.logger.debug("Received combined beacon committee selection proof for different slot", {
expected: slot,
actual: combinedSelection.slot,
index: committeeIndex,
validatorIndex,
});
continue;
}
Comment thread
nflaig marked this conversation as resolved.

const isAggregator = isAggregatorFromCommitteeLength(committeeLength, combinedSelection.selectionProof);

if (isAggregator) {
Expand Down
Loading