chore: log aggregation selection errors to debug - #8709
Merged
Conversation
Contributor
Summary of ChangesHello @nflaig, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adjusts the logging severity for specific aggregation selection and proof-related messages within the validator services. Previously logged as errors or warnings, these messages are now considered less critical and have been downgraded to debug level. This change addresses potential log noise stemming from recent shifts in validator client behavior and the transition from per-slot to per-epoch processing, ensuring that only truly critical issues generate high-severity alerts. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to reduce log noise by downgrading the log level for aggregation selection errors from error and warn to debug. The changes are consistent across attestationDuties.ts and syncCommitteeDuties.ts.
While the intent to reduce noise from expected errors is clear, I've suggested changing the log level from error to warn instead of debug for cases where the entire aggregation selection task fails. This provides a balance between reducing noise and ensuring that potentially persistent, actionable issues with DVT middleware remain visible in default log configurations. The changes from warn to debug for individual missing selection proofs seem appropriate to reduce high-volume, low-signal logs.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Dec 19, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #8709 +/- ##
=========================================
Coverage 52.06% 52.06%
=========================================
Files 848 848
Lines 64787 64787
Branches 4771 4771
=========================================
Hits 33729 33729
Misses 30989 30989
Partials 69 69 🚀 New features to boost your workflow:
|
Member
|
🎉 This PR is included in v1.39.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These errors aren't really critical and might be common right now because we moved from per slot to per epoch in #8669 and not all validator clients doing the same will cause calls to time out if signature threshold in DVT middleware is not reached.