fix: avoid calling committee selection apis if there are no duties

[nflaig]

Since #8669 we might call the committee selection apis even if we don't have any duties which is unnecessary and charon doesn't like it.

lodestar-1  | Dec-19 16:16:47.001[]                error: Error on sync committee aggregation selection slot=13278082 - JSON is not an array
lodestar-1  | Error: JSON is not an array
lodestar-1  |     at value_fromJsonArray (file:///usr/app/node_modules/@chainsafe/ssz/src/type/arrayBasic.ts:162:11)
lodestar-1  |     at ListCompositeType.fromJson (file:///usr/app/node_modules/@chainsafe/ssz/src/type/array.ts:121:12)
lodestar-1  |     at ApiResponse.value (file:///usr/app/packages/api/src/utils/client/response.ts:115:51)
lodestar-1  |     at SyncCommitteeDutiesService.runDistributedAggregationSelectionTasks (file:///usr/app/packages/validator/src/services/syncCommitteeDuties.ts:385:36)
lodestar-1  |     at processTicksAndRejections (node:internal/process/task_queues:103:5)

[gemini-code-assist]

Summary of Changes

Hello @nflaig, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a targeted fix to optimize the validator service by preventing redundant calls to committee selection APIs. The change ensures that these API endpoints are only invoked when there are actual duties to process, thereby avoiding unnecessary computations and resolving a specific incompatibility that arose with Charon due to previous changes. This leads to more efficient resource utilization and a more robust system.

Highlights

• Issue Resolution: This PR addresses an issue where committee selection APIs were being called even when there were no duties to process, which was unnecessary and caused problems with Charon.
• API Call Optimization: Introduced early return checks in the runDistributedAggregationSelectionTasks methods for both attestation and sync committee duties, preventing API calls when the duties array is empty.
• Improved Compatibility: The fix ensures better compatibility and prevents unnecessary operations, particularly in scenarios involving Charon.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a simple but important fix to avoid unnecessary API calls to the committee selection endpoints when there are no duties to process. The changes in attestationDuties.ts and syncCommitteeDuties.ts add a guard clause at the beginning of the runDistributedAggregationSelectionTasks methods to check if the duties array is empty. This is a clean and effective way to prevent sending empty requests, which aligns with the PR's goal. The implementation is correct and improves the robustness and efficiency of the validator. No issues were found in the changes.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.06%. Comparing base (493cc12) to head (e087448).
⚠️ Report is 1 commits behind head on unstable.

Additional details and impacted files

@@            Coverage Diff            @@
##           unstable    #8708   +/-   ##
=========================================
  Coverage     52.06%   52.06%           
=========================================
  Files           848      848           
  Lines         64787    64787           
  Branches       4771     4771           
=========================================
  Hits          33729    33729           
  Misses        30989    30989           
  Partials         69       69           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[wemeetagain]

🎉 This PR is included in v1.39.0 🎉