chore: review block input refactor

[nflaig]

Review #8200

[gemini-code-assist]

Summary of Changes

Hello @nflaig, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on refactoring and cleanup, enhancing the clarity and encapsulation of several core components. Key changes include optimizing the conditional logic for processing different block input types, encapsulating the network logger for better internal management, and tidying up type-related declarations in the block synchronization module. The overall impact is improved code maintainability and a more robust internal structure.

Highlights

• Block Input Processing Logic: Refactored the conditional logic for handling different types of block inputs (data column sidecars and blob sidecars) in both the API and chain import functions. This change streamlines the flow by using else if statements and removes redundant checks for array length, relying solely on type-checking functions.
• Network Logger Encapsulation: Improved encapsulation of the network logger by moving the logger property from the public INetwork interface to a private member within the Network class. This ensures the logger is an internal concern of the Network implementation.
• Block Synchronization Type Cleanup: Cleaned up type assertions and removed an unused import (PendingRootHex) within the block synchronization logic, simplifying the code and potentially improving type inference.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a series of beneficial refactorings and cleanups. The logic for handling different BlockInput types has been improved by using else if for mutually exclusive conditions and removing redundant checks, which enhances correctness and readability. Encapsulation is improved by making the Network class's logger private. Furthermore, type safety has been strengthened by replacing unsafe type assertions with proper type guards in unknownBlock.ts. The removal of unused imports and commented code also contributes to better code hygiene. Overall, these are excellent changes that improve the quality and maintainability of the codebase.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.41%. Comparing base (b829484) to head (0fd1415).
⚠️ Report is 1 commits behind head on mkeil/refactor-block-input-on-unstable.

Additional details and impacted files

@@                            Coverage Diff                             @@
##           mkeil/refactor-block-input-on-unstable    #8398      +/-   ##
==========================================================================
- Coverage                                   54.42%   54.41%   -0.02%     
==========================================================================
  Files                                         853      853              
  Lines                                       63932    63930       -2     
  Branches                                     4788     4785       -3     
==========================================================================
- Hits                                        34797    34788       -9     
- Misses                                      29064    29071       +7     
  Partials                                       71       71              

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.