Skip to content

Conversation

@matthewkeil
Copy link
Member

Motivation

There is a bug when making byRoot columns requests. The request type was changed to in #7782 and a subtle bug was introduced in how we parse the response.

@matthewkeil matthewkeil requested a review from a team as a code owner June 5, 2025 05:57
@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.37%. Comparing base (0a673a0) to head (b243354).
Report is 1 commits behind head on peerDAS.

Additional details and impacted files
@@           Coverage Diff            @@
##           peerDAS    #7917   +/-   ##
========================================
  Coverage    54.37%   54.37%           
========================================
  Files          840      840           
  Lines        61989    61989           
  Branches      4653     4654    +1     
========================================
  Hits         33706    33706           
  Misses       28215    28215           
  Partials        68       68           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthewkeil matthewkeil merged commit 3807a44 into peerDAS Jun 5, 2025
23 of 24 checks passed
@matthewkeil matthewkeil deleted the mkeil/fix-columns-by-root-request-length branch June 5, 2025 06:52
@twoeths
Copy link
Contributor

twoeths commented Jun 5, 2025

confirm that it works in all deployed nodes

Screenshot 2025-06-05 at 13 58 27

cannot search for "Missing or mismatching" in the last 30m

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.34.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants