-
-
Notifications
You must be signed in to change notification settings - Fork 412
fix: add special handling for blob schedule when asserting equal params #7859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7859 +/- ##
============================================
- Coverage 55.81% 55.80% -0.02%
============================================
Files 823 823
Lines 58157 58180 +23
Branches 4496 4499 +3
============================================
+ Hits 32463 32467 +4
- Misses 25627 25646 +19
Partials 67 67 🚀 New features to boost your workflow:
|
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
May 27, 2025
Member
|
🎉 This PR is included in v1.31.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow up to #7729, we need to handle blob schedule separately from generic string comparison of values, otherwise what we compare are shallow stringified arrays. It does not validate the object properties and on length mismatch we just get the following error
Description
Add special handling for blob schedule when asserting equal params
EPOCHandMAX_BLOBS_PER_BLOCK