Skip to content

fix: do not throw error when trying to prune missing directory #7257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nflaig merged 1 commit into from
Nov 29, 2024
Merged

fix: do not throw error when trying to prune missing directory #7257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/cli/src/util/pruneOldFilesInDir.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ import fs from "node:fs";
import path from "node:path";

export function pruneOldFilesInDir(dirpath: string, maxAgeMs: number): number {
if (!fs.existsSync(dirpath)) {
return 0; // Nothing to prune
}

let deletedFileCount = 0;
for (const entryName of fs.readdirSync(dirpath)) {
const entryPath = path.join(dirpath, entryName);
Expand Down
4 changes: 4 additions & 0 deletions packages/cli/test/unit/util/pruneOldFilesInDir.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ describe("pruneOldFilesInDir", () => {
expect(fs.existsSync(emptyDir)).toBe(false);
});

it("should handle missing directories", () => {
expect(() => pruneOldFilesInDir(path.join(dataDir, "does-not-exist"), DAYS_TO_MS)).not.toThrowError();
});

function createFileWithAge(path: string, ageInDays: number): void {
// Create a new empty file
fs.closeSync(fs.openSync(path, "w"));
Expand Down