fix: ssz v0.17.1 - #7035
Merged
Merged
Conversation
ensi321
approved these changes
Aug 19, 2024
nflaig
approved these changes
Aug 19, 2024
Member
|
ssz 0.17.1 is now published with the fix |
This reverts commit 7aa6678.
nflaig
approved these changes
Aug 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## electra-fork-rebasejul30 #7035 +/- ##
===========================================================
Coverage ? 49.38%
===========================================================
Files ? 589
Lines ? 39200
Branches ? 2247
===========================================================
Hits ? 19358
Misses ? 19801
Partials ? 41 |
wemeetagain
approved these changes
Aug 20, 2024
g11tech
pushed a commit
that referenced
this pull request
Aug 23, 2024
* fix: work around for sliceFrom() api * Revert "fix: work around for sliceFrom() api" This reverts commit 7aa6678. * fix: upgrade ssz
g11tech
pushed a commit
that referenced
this pull request
Aug 27, 2024
* fix: work around for sliceFrom() api * Revert "fix: work around for sliceFrom() api" This reverts commit 7aa6678. * fix: upgrade ssz
philknows
pushed a commit
that referenced
this pull request
Sep 3, 2024
* fix: work around for sliceFrom() api * Revert "fix: work around for sliceFrom() api" This reverts commit 7aa6678. * fix: upgrade ssz
Member
|
🎉 This PR is included in v1.22.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There's a bug in
sliceFrom()api so need a work around for it ChainSafe/ssz#394Description
Call
getAllReadonly()api to load all nodes before usingsliceFrom()